Beginning to believe that @Gargron doesn't want me contributing to #mastodon — he's now partially recreated three of my pull requests that I've worked on.
My PRs didn't ship because I needed feedback from the team who were busy.
Like, I'm happy to spend the time and money to contribute to Mastodon, but it's horrifically rude to just redo someone's work when they've put a tonne of work into doing something.
He's also done this to me in the past in 2018 with the report management tools.
Emelia 👸🏻
in reply to Emelia 👸🏻 • • •His PR: github.com/mastodon/mastodon/p…
My PRs:
- github.com/mastodon/mastodon/p…
- github.com/mastodon/mastodon/p…
His PR: github.com/mastodon/mastodon/p…
My PR: discord.com/channels/@me/12738…
Like seriously, I spend a lot of time trying to get the moderation features right, and thinking through all the feedback I've read when I've reviewed all the open moderation issues on the project.
@Gargron
Discord - Group Chat That’s All Fun & Games
DiscordEmelia 👸🏻
in reply to Emelia 👸🏻 • • •All of the PRs that @Gargron has redone of mine only partially improve things.
Report forwarding? Yeah, you want to track which domains you've actually forwarded to, especially on reports that could be forwarded to multiple other domains. You also want to be able to override the report comment incase there's user sensitive data in the comment that shouldn't be forwarded.
I spent a long time thinking this through and trying to get the UI right.
Emelia 👸🏻
in reply to Emelia 👸🏻 • • •The Reports list and details pages? Once again @Gargron's quick PRs don't actually address the issues where the layout was confusing, didn't show enough information or displayed it in confusing ways.
The new theme in 4.3 also completely broke the visual hierarchy of the Report details page, which I've done a bunch of work on redesigning to make clearer github.com/mastodon/mastodon/i… (I haven't opened a branch yet because I wanted to have the UX right first)
New design for Admin panel makes Reports hard to read · Issue #31444 · mastodon/mastodon
GitHubEmelia 👸🏻
in reply to Emelia 👸🏻 • • •Here's the same thing happening in 2018 when I was contributing to the moderation tools:
My PR: github.com/mastodon/mastodon/p…
His PR: github.com/mastodon/mastodon/p…
My PRs all try to address a single area / issue, as that's what the team has asked for whenever I've submitted larger PRs touching on multiple issues.
@Gargron
Feature: Improve remote report display by ThisIsMissEm · Pull Request #7062 · mastodon/mastodon
GitHubEmelia 👸🏻
in reply to Emelia 👸🏻 • • •I'm no longer just some "new developer" working on the project, instead I've 92 merged pull requests, and 37 open, waiting for review.
I'm fairly certain that @Gargron only even thought of report forwarding because after his first PR that conflicted with my ongoing work, I mentioned that I'd been working on report forwarding in a conversation.
Emelia 👸🏻
in reply to Emelia 👸🏻 • • •this is really pissing me off, because like, I could've been spending that time working on other things, like FIRES, but instead I pushed hard on Mastodon moderation features to *try* to move things forwards for 4.3
Features that @Gargron had left underloved for months or years, not responding to moderator feedback.