Skip to main content

Starting the week with a very small pull request I just published 🤭

I'm the first to scream when I need to review a gigantic PR, but sometimes working on a big code refactoring after months working on a project doesn't really allow for small ones.

All in all I removed 560 lines of code so I guess it makes it more okay ? 🙈

#rust #rustlang #git #programming

#rustlang #programming #rust #git
in reply to Adrian Tombu 🌱

John Stracke
John Stracke
• •

Biggest PR I ever did was 7000 lines. Special circumstances—I was leaving my team, and my lead asked me to resurrect an effort we'd put aside earlier. I had time to do it, but not to break it down into small pieces.

(Amazingly, the engineer who volunteered to review it got it done in a week.)

⇧